Lazy render logs to increase performance #25046
Merged
+45
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30072 | |
| Version | PR #25046 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a5a8e3d | |
| Installation URL | 3ltjmldc9cpu0 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30072 | |
| Version | PR #25046 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a5a8e3d | |
| Installation URL | 2f1s3gdirqra8 |
twstokes
changed the title
dcalhoun
reviewed
Dec 5, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
This tested well for me. 🎉 Thanks!
I'll note these changes do not impact the experimental "New Support" feature. The logic for that resides in Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift. Claude suggested the following for applying the lazy render optimization there. I did not test the suggestion, nor do we necessarily need to address it in this PR, but I share it for additional context.
New Support lazy render optimization diff
diff --git a/Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift b/Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift
index 88f8f48ced..748c81f075 100644
--- a/Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift
+++ b/Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift
@@ -8,14 +8,14 @@ struct ActivityLogDetailView: View {
enum ViewState: Equatable {
case loading
- case loaded(String, isSharing: Bool)
+ case loaded([String], isSharing: Bool)
case error(Error)
static func == (lhs: ActivityLogDetailView.ViewState, rhs: ActivityLogDetailView.ViewState) -> Bool {
return switch (lhs, rhs) {
case (.loading, .loading): true
- case (.loaded(let lhscontent, let lhsisSharing), .loaded(let rhscontent, let rhsisSharing)):
- lhscontent == rhscontent && lhsisSharing == rhsisSharing
+ case (.loaded(let lhsLines, let lhsisSharing), .loaded(let rhsLines, let rhsisSharing)):
+ lhsLines == rhsLines && lhsisSharing == rhsisSharing
case (.error, .error): true
default: false
}
@@ -38,8 +38,8 @@ struct ActivityLogDetailView: View {
switch self.state {
case .loading:
self.loadingView
- case .loaded(let content, _):
- self.loadedView(content: content)
+ case .loaded(let lines, _):
+ self.loadedView(lines: lines)
case .error(let error):
self.errorView(error: error)
}
@@ -54,11 +54,11 @@ struct ActivityLogDetailView: View {
}
}
.sheet(isPresented: self.$isDisplayingShareSheet, onDismiss: {
- guard case .loaded(let content, _) = self.state else {
+ guard case .loaded(let lines, _) = self.state else {
return
}
- self.state = .loaded(content, isSharing: false)
+ self.state = .loaded(lines, isSharing: false)
}, content: {
ActivityLogSharingView(applicationLog: applicationLog) {
AnyView(erasing: Text("TODO: A new support request with the application log attached"))
@@ -87,15 +87,21 @@ struct ActivityLogDetailView: View {
}
@ViewBuilder
- func loadedView(content: String) -> some View {
+ func loadedView(lines: [String]) -> some View {
ScrollView {
- VStack(alignment: .leading) {
- TextEditor(text: .constant(content))
- .font(.system(.body, design: .monospaced))
- .fixedSize(horizontal: false, vertical: true)
- .scrollDisabled(true)
- .padding()
+ LazyVStack(alignment: .leading, spacing: 0) {
+ logLinesContent(lines: lines)
}
+ .font(.system(.body, design: .monospaced))
+ .padding()
+ }
+ }
+
+ @ViewBuilder
+ private func logLinesContent(lines: [String]) -> some View {
+ ForEach(Array(lines.enumerated()), id: \.offset) { _, line in
+ Text(line)
+ .frame(maxWidth: .infinity, alignment: .leading)
}
}
@@ -110,19 +116,22 @@ struct ActivityLogDetailView: View {
private func loadLogContent() async {
do {
let content = try await self.dataProvider.readApplicationLog(applicationLog)
+ let lines = content
+ .split(separator: "\n", omittingEmptySubsequences: false)
+ .map(String.init)
- self.state = .loaded(content, isSharing: false)
+ self.state = .loaded(lines, isSharing: false)
} catch {
self.state = .error(error)
}
}
private func startSharing() {
- guard case .loaded(let content, _) = self.state else {
+ guard case .loaded(let lines, _) = self.state else {
return
}
- state = .loaded(content, isSharing: true)
+ state = .loaded(lines, isSharing: true)
}
}
WordPress/Classes/ViewRelated/Me/Help & Support/SupportActivityDetailsView.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks @dcalhoun! I wasn't even aware of that view. I applied the same functionality to it and noticed a massive difference in memory usage when viewing a log:
|
|
dcalhoun
approved these changes
Dec 5, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Tested well for me—both the legacy and new support UI. 🚀
I applied the same functionality to it and noticed a massive difference in memory usage when viewing a log:
Whoa!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of rendering one potentially massive
Textview, lazy load it via array of strings. Logs on my device were large enough to crash the app due to the main thread watchdog.lazy_logs.mp4
Testing instructions
Legacy support view
Ensure new support experience feature is disabled.
New support view
Ensure new support experience feature is enabled.